Skip to content

Add guarded logging extensions and apply throughout codebase#388

Merged
rido-min merged 2 commits intonext/corefrom
next/core-rm-ca1873
Mar 23, 2026
Merged

Add guarded logging extensions and apply throughout codebase#388
rido-min merged 2 commits intonext/corefrom
next/core-rm-ca1873

Conversation

@rido-min
Copy link
Member

Introduce LoggerExtensions with LogInformationGuarded and LogTraceGuarded to prevent expensive log message construction when not enabled. Replace direct LogInformation and LogTrace calls with guarded versions in core classes. Remove CA1873 suppression and update CA2227 justification. Improves logging performance and consistency.

Introduce LoggerExtensions with LogInformationGuarded and LogTraceGuarded to prevent expensive log message construction when not enabled. Replace direct LogInformation and LogTrace calls with guarded versions in core classes. Remove CA1873 suppression and update CA2227 justification. Improves logging performance and consistency.
@rido-min rido-min requested review from MehakBindra and singhk97 and removed request for MehakBindra March 20, 2026 23:40
@rido-min rido-min added the CORE label Mar 20, 2026
Copy link
Collaborator

@singhk97 singhk97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this supposed to be a performance improvement? (just read the description)

@rido-min rido-min merged commit 32a0b87 into next/core Mar 23, 2026
7 checks passed
@rido-min rido-min deleted the next/core-rm-ca1873 branch March 23, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants